Detect conditional code

[llaville]

Some issues #128, #155, #159 were reported about conditional code.
We are in front of a challenge, because PHP-Parser 1.0.2 is not yet able to check pre-conditions (if code found) before traversing the AST.

A study case to understand what I means is the issue #155, where results depend on lexical order of fallback implementation.

I'll implement here the solution proposed in PHP-Parser

[llaville]

Node processor were implemented in Reflect with commit llaville/php-reflect@c64e412

[llaville]

Depending on parsing file order, some code conditions are not detected

[llaville]

Finally, I've found a compromise solution. A little loss of performance, but a real result.

[llaville]

Files to process need to be reordered. See commit llaville/php-reflect@a468e37

[llaville]

Even, if we have solved challenge to identify conditional code on multiple files, and in different lexical order, we can improved again the detection.

See PHP_CodeSniffer 2.2 is a very good study case !

[llaville]

To solve detection of conditional code in multiple files, I've first (#160 (comment)) implemented a queue to sort file by priority (cond code first).

But, always with PHP Code Sniffer 2.2, I found it's not enough especially when using the reg exp and Symfony Finder filter iterator.

We can found in such condition, term (like "defined") in a string. That did not tell us that we are in face of conditional code with php defined function.

Example:
PHP_CodeSniffer-2.2.0\CodeSniffer\Standards\PSR2\Sniffs\Classes\ClassDeclarationSniff.php Line 80 and 82

I'll then apply a new strategy, replacing reg exp by php tokens

[llaville]

Commit llaville/php-reflect@ba1df8f is not enough to solve the situation.

If you don't understand, try with following snippet code

<?php

$content1 = <<<EOL
if (defined('T_TRAIT') === false) {
    define('T_TRAIT', 1105);
}
EOL;
$content2 = <<<EOL
    recordMetric('Class defined in namespace', 'no');
EOL;
$content3 = <<<EOL
    recordMetric('Class defined (in namespace)', 'no');
EOL;

$matches = null;

preg_match('/defined\s*\(/i', $content3, $matches);

var_export($matches);

$content1 and $content2 are OK, but $content3 gave a false positive with fix llaville/php-reflect@ba1df8f

[llaville]

confirmed now llaville/php-reflect@42eb4e9 by the additional token strategy

[llaville]

Not enough (: There is still another case not catched here.

When we use a conditional code before it was defined, even with file sort startegy.

For example, see PHP_CodeSniffer-2.2.0\CodeSniffer\File.php, and getDeclarationName() method that used T_TRAIT.

T_TRAIT is defined later in queue file PHP_CodeSniffer-2.2.0.tgz\PHP_CodeSniffer-2.2.0\CodeSniffer\Tokens.php.

Too late, and it generates a FALSE positive !

[llaville]

With llaville/php-reflect@42eb4e9...fb522bb we finally solved previous conflict issue