-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncaught Error: Object of class PhpParser\Node\UnionType could not be converted to string #292
Comments
Could you give your platform context (php and compatinfo version) ? With PHP 7.2.34 and See below
|
PHP 7.4.14 (cli) (built: Jan 5 2021 10:45:06) ( NTS ) phpCompatInfo version 5.4.2 DB version 2.19.0 built Oct 05 2020 09:18:56 CEST |
Sorry I cannot reproduced this error. I've the same results with PHP 7.2.34, 7.3.26, and 7.4.14 (with almost the same dependeny versions installed with Composer except for PHP 7.2 and hoa/* components that are used only by humbug/box) |
PHP 7.4.14 (cli) (built: Jan 20 2021 22:21:45) ( NTS ) I get same issue:
|
could you precise how you install compatinfo (and what is dependencies installed : composer show command results) and last but not least souce code analysed (where you get it and how installed). |
installed by phpstorm composer update mechanism (added into composer.json):
updated composer inside phpstorm as
|
and about source code analysed ? what is the source code ? specific version or a branch ? |
yah, this is private source of our project. but available open community source by this link: observium-ce |
sorry but still cannot reproduced issue. Here are my steps
WARNING Already some differences with your installation That gave me report without error
My platform is :
I cannot fix an issue that I can't reproduce ! |
As I'm not able to reproduce this issue, if one of you @remicollet, @landy2005 can do the change and test for me, to see if it solve the problem. Replaces https://github.com/llaville/php-compat-info/blob/master/src/Bartlett/CompatInfo/PhpParser/NodeVisitor/VersionResolverVisitor.php#L166-L188 Thanks in advance. |
It breaks somewhere else
|
Please try on git snapshot |
@remicollet Very strange. I've cloned the proxy-manger project, and run analysis on |
Run it on the top folder to include everything, src, test, bin, ... |
Ok got it now, I can reproduce, and I'll investigate. Found origin of issue : https://github.com/FriendsOfPHP/proxy-manager-lts/blob/1.x/tests/ProxyManagerTestAsset/ClassWithPhp80TypedMethods.php#L19-L20 With corresponding nodes dump
Will provide a patch for bug fix release 5.4.3, and 6.0.x-dev tomorrow. |
@remicollet branch 5.4 is available with fix. Waiting your green light before to release the new bug fix release 5.4.3 |
Bug fix release 5.4.3 is on way ! |
Sorry being late (mostly offline last week, and also this week) So I confirm 5.4.3 works. |
Trying to analyse https://github.com/FriendsOfPHP/proxy-manager-lts
The text was updated successfully, but these errors were encountered: