Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add newline to error message #224

Closed
wants to merge 8 commits into from
Closed

add newline to error message #224

wants to merge 8 commits into from

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Sep 22, 2016

the error message lacks trailing newline ( is my shell prompt):

➔ ./phpcompatinfo.phar 
Your platform does not statisfy CompatInfo minimum requirements
- Expected PHP extension pdo_sqlite loaded to use SQLite DataBase, is missing➔ 

also the spelling error submitted as separate PR as it is in different project:
llaville/php-compatinfo-db#6

altho imho db is wrong package for requirement check function, that code should be in this repository.

@llaville
Copy link
Owner

The diagnose:run command that is shared betwen php-compatinfo and php-reflect was refactored to use the dependency https://github.com/zendframework/ZendDiagnostics

PHP-Reflect 4.1 (stable) should be released tomorrow

@remicollet
Copy link
Contributor

remicollet commented Mar 1, 2017

@llaville notice that the LICENSE file is missing in ZendDiagnostics, which make redistribution impossible.

In short, if you distribute it in your phar, you are going to violate BSD license terms.

=> zendframework/zend-diagnostics#77

@llaville
Copy link
Owner

llaville commented Mar 1, 2017

@remicollet Thanks for review (and license missing)

@llaville
Copy link
Owner

llaville commented Sep 3, 2020

Thanks @glensc, but I'll close this issue that won't be fixed, because I've let down diagnose command in next version 5.4 that will come shortly now (next week, see ROADMAP #266)

@llaville llaville closed this Sep 3, 2020
@glensc glensc deleted the eol branch September 3, 2020 07:19
@glensc
Copy link
Contributor Author

glensc commented Sep 3, 2020

@llaville the PR commits in this PR are messed up anyway because somebody else did either:

  • force pushed base branch (master)
  • pushed more commits to my branch

I created PR with only with two commits that were authored by me. you can cherry pick them if you wish.

@glensc
Copy link
Contributor Author

glensc commented Sep 3, 2020

also here are comments totally unrelated to my PR, perhaps it's github who messed it up?

@llaville
Copy link
Owner

llaville commented Sep 3, 2020

@glensc No it's me, I've waited too much time to reply to your contribution (sorry for that)

I'm focus now to finish (almost ready) the final version 5.4.0 (as I said that let down some previous features, and monolithic code) and prepare the way to a v6.0 that will simplify CLI (fully drop down PHP Reflect) and refactor console application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants