-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add newline to error message #224
Conversation
The diagnose:run command that is shared betwen php-compatinfo and php-reflect was refactored to use the dependency https://github.com/zendframework/ZendDiagnostics PHP-Reflect 4.1 (stable) should be released tomorrow |
@llaville notice that the LICENSE file is missing in ZendDiagnostics, which make redistribution impossible. In short, if you distribute it in your phar, you are going to violate BSD license terms. |
@remicollet Thanks for review (and license missing) |
@llaville the PR commits in this PR are messed up anyway because somebody else did either:
I created PR with only with two commits that were authored by me. you can cherry pick them if you wish. |
also here are comments totally unrelated to my PR, perhaps it's github who messed it up? |
@glensc No it's me, I've waited too much time to reply to your contribution (sorry for that) I'm focus now to finish (almost ready) the final version 5.4.0 (as I said that let down some previous features, and monolithic code) and prepare the way to a v6.0 that will simplify CLI (fully drop down PHP Reflect) and refactor console application. |
the error message lacks trailing newline (
➔
is my shell prompt):also the spelling error submitted as separate PR as it is in different project:
llaville/php-compatinfo-db#6
altho imho db is wrong package for requirement check function, that code should be in this repository.