Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies #283

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Add missing dependencies #283

merged 1 commit into from
Oct 6, 2020

Conversation

remicollet
Copy link
Contributor

From phpcompatinfo report for phpcompatinfo sources

Classes Analysis

    Class                                                                      REF        EXT min/Max     PHP min/Max 
    ArrayIterator                                                              spl        5.0.0           5.0.0       
...
  U Psr\Log\LoggerInterface                                                    user                       5.3.0       
...
  U Symfony\Component\Config\FileLocator                                       user                       5.3.0       
  U Symfony\Component\Console\Event\ConsoleCommandEvent                        user                       5.3.0       
  U Symfony\Component\Console\Event\ConsoleTerminateEvent                      user                       5.3.0       
  U Symfony\Component\Console\Formatter\OutputFormatterInterface               user                       5.3.0       
  U Symfony\Component\Console\Formatter\OutputFormatterStyle                   user                       5.3.0       
  U Symfony\Component\Console\Helper\FormatterHelper                           user                       5.3.0       
  U Symfony\Component\Console\Helper\ProgressBar                               user                       5.3.0       
  U Symfony\Component\Console\Helper\TableSeparator                            user                       5.3.0       
  U Symfony\Component\Console\Input\ArgvInput                                  user                       5.3.0       
  U Symfony\Component\Console\Input\InputArgument                              user                       5.3.0       
  U Symfony\Component\Console\Input\InputDefinition                            user                       5.3.0       
  U Symfony\Component\Console\Input\InputInterface                             user                       5.3.0       
  U Symfony\Component\Console\Input\InputOption                                user                       5.3.0       
  U Symfony\Component\Console\Output\ConsoleOutput                             user                       5.3.0       
  U Symfony\Component\Console\Output\OutputInterface                           user                       5.3.0       
  U Symfony\Component\DependencyInjection\ContainerBuilder                     user                       5.3.0       
  U Symfony\Component\DependencyInjection\ContainerInterface                   user                       5.3.0       
  U Symfony\Component\DependencyInjection\Loader\PhpFileLoader                 user                       5.3.0       
  U Symfony\Component\EventDispatcher\EventDispatcher                          user                       5.3.0       
  U Symfony\Component\EventDispatcher\EventDispatcherInterface                 user                       5.3.0       
  U Symfony\Component\EventDispatcher\EventSubscriberInterface                 user                       5.3.0       
  U Symfony\Component\EventDispatcher\GenericEvent                             user                       5.3.0       
  U Symfony\Component\Finder\Finder                                            user                       5.3.0       
  U Symfony\Component\Finder\SplFileInfo                                       user                       5.3.0       
  U Symfony\Component\Serializer\Normalizer\NormalizerInterface                user                       5.3.0       
  U Symfony\Component\Stopwatch\Stopwatch                                      user                       5.3.0       
...

@remicollet
Copy link
Contributor Author

remicollet commented Oct 6, 2020

P.S. will be nice to have the "hacktoberfest" topic for this repository, or "hacktoberfest-accepted" label for PR.

See https://hacktoberfest.digitalocean.com/

Copy link
Owner

@llaville llaville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implicit/explicit dependencies debate ;)
It will now an old history. And more with v6, when php reflect will be removed

@llaville llaville merged commit 3bf8ec0 into llaville:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants