Update -break-insert with the -f (pending flag) to not require an additional parameter #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itional parameter According to [this](https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Breakpoint-Commands.html#GDB_002fMI-Breakpoint-Commands) document, `-break-insert`'s `-f` flag is to tell the debugger to create a pending breakpoint if the location is not found. The additional parameter should not be necessary. ``` ‘-f’ If location cannot be parsed (for example if it refers to unknown files or functions), create a pending breakpoint. Without this flag, GDB will report an error, and won’t create a breakpoint, if location cannot be parsed. ‘-d’ ```
|
Fixes #3 |
WardenGnaw
added a commit
to microsoft/MIEngine
that referenced
this pull request
Dec 31, 2019
From #946 and also with @puremourning's help, lldb-mi has changed to not need the 'on' keyword due to lldb-tools/lldb-mi#2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugs.llvm.org/show_bug.cgi?id=28698
According to this document,
-break-insert's-fflag is to tell the debugger to create a pending breakpoint if the location is not found. The additional parameter should not be necessary.