maxStale alone never send back cache

[matthieurosset]

Hello,

Thanks a lot for your work, your package is really helpful.

I found an issue in DioCacheInterceptor.onError. If I define a Duration for maxStale but I don't define any exception for hitCacheOnErrorExcept, interceptor never send me back my cache when an error occurs (for example : an error 500). In my case, I don't want to define any exception.

Hope this helps !

[llfbandit]

Thanks but you only need to provide empty hitCacheOnErrorExcept list to make this work.
Am I wrong ?

[matthieurosset]

No, you're right, it can be that way. But in this case, add a required to this parameter or define an empty array by default. I had to debug your package to understand why my cache was not returned.

[llfbandit]

null value => No cache hit on error.
value => Cache hit on error, excepted given status codes.

So, as we need both, we must keep hitCacheOnErrorExcept optional.

[matthieurosset]

If you don't define maxStale, what do you expect ? Return a cache without time limit ?

What I expected was "no cache on error".

[llfbandit]

maxStale is not related to hitCacheOnErrorExcept.
With maxStale, the cache store won't provide the cached value if maxStale is in the past.
This is mostly useful if the origin server has no cache set up.

Otherwise, the cached value expires according standard HTTP expiration headers.

[matthieurosset]

Okay, I understand your point for maxStale.

For me, it's still weird to give an empty list to an optional exception list to hit my cache in case of errors. If I don't have any exceptions, I expect to get all of my items back and not any of them. Looks like an hidden feature. An additionnal bool parameter "hitCacheOnError" would be more clear.