Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the ability to calculate stacking #70

Merged
merged 35 commits into from
Aug 3, 2020
Merged

add the ability to calculate stacking #70

merged 35 commits into from
Aug 3, 2020

Conversation

dz-ss
Copy link
Contributor

@dz-ss dz-ss commented Jul 27, 2020 •
edited by tybug
Loading

Breaking changes:

  • hit_objects is now a function
  • hit_objects_no_spinners has been removed, pass spinners=False to hit_objects instead

fixes issues from #67

InvisibleSymbol and others added 30 commits April 11, 2020 20:06
@InvisibleSymbol
add the ability to calculate stacking
5f8dac5 
breaking changes:
  * hit_objects is now a function
  * hit_objects_no_spinners has been removed, use the spinner argument of the hit_objects function instead
@InvisibleSymbol
use object name instead of an index char
e2ec77c
@InvisibleSymbol
remove debug output
f96ae2b
@InvisibleSymbol
add stack_height to HitObject
0c13e6a
@InvisibleSymbol
don't directly modify attribute
c41bf11
@InvisibleSymbol
flip sliders when hard_rock is passed
4c14dc5
@InvisibleSymbol
fix incorrect x position
7df78c8
@InvisibleSymbol
add basic tests for stacking
47c4879
@InvisibleSymbol
don't memoize hit_objects
e090c4b
@InvisibleSymbol
make hit_objects arguments keyword-only
0b84a7f
@InvisibleSymbol
replace circles and sliders attributes as arguments in hit_objects()
ba195b0 
bm.circles is now bm.hit_objects(circles=True, sliders=False, spinners=False)

bm.sliders is now bm.hit_objects(circles=False, sliders=True, spinners=False)
@InvisibleSymbol
update comment of hit_objects function
781850c
@InvisibleSymbol
update comments again
3fa4dd8
@InvisibleSymbol
use mod property of hitobjects
f919115
@InvisibleSymbol
Merge branch 'master' of https://github.com/llllllllll/slider into st…
5f029ca 
…acking
@InvisibleSymbol
fix test
0c8ede2
@InvisibleSymbol
remove duplicated imports
7d9537c
@InvisibleSymbol
fix blank lines
1557d97
@InvisibleSymbol
fix indentation
db7fb9c
@InvisibleSymbol
make Beatmap keyword only
921e964
@InvisibleSymbol
remove stacking to separate function
71b40ba
@InvisibleSymbol
shorten comments
13c8b47
@InvisibleSymbol
remove unused attribute
3e7ea51
@InvisibleSymbol
rewrite test to use a constructed beatmap
8f4a93c
@InvisibleSymbol
add stacking code for old beatmaps
16d4dc7
@InvisibleSymbol
fix not slicing list correctly
5a82b42
@InvisibleSymbol
use old stacking for versions bellow 6
0b15815
@dz-ss
fix stacking and slider end time
adfe173
@dz-ss
remove print
4c2277b
@dz-ss
fix test values for stack offset and end time
0d3ace9
@tybug tybug mentioned this pull request Aug 2, 2020
Closed
@tybug tybug merged commit bf590d1 into llllllllll:master Aug 3, 2020
@tybug tybug mentioned this pull request Sep 29, 2020
Merged
@tybug tybug mentioned this pull request May 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dz-ss @tybug @InvisibleSymbol