Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not overwrite $GRADIO_SERVER_PORT with the default value if the variable is already set #1921

Merged
merged 1 commit into from Feb 10, 2024
Merged

Do not overwrite $GRADIO_SERVER_PORT with the default value if the variable is already set #1921

merged 1 commit into from Feb 10, 2024

Conversation

rsl8
Copy link
Contributor

@rsl8 rsl8 commented Jan 13, 2024

No description provided.

@rsl8 rsl8 requested a review from lllyasviel as a code owner January 13, 2024 23:15
mashb1t
mashb1t approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@mashb1t mashb1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mashb1t mashb1t added the Size S small change, basically no testing needed label Feb 9, 2024
@mashb1t mashb1t changed the base branch from main to develop February 10, 2024 17:41
@mashb1t mashb1t merged commit 05562dc into lllyasviel:develop Feb 10, 2024
mashb1t pushed a commit that referenced this pull request Feb 10, 2024
@rsl8 @mashb1t
fix: do not overwrite $GRADIO_SERVER_PORT if it is already set (#1921)
e4929a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashb1t mashb1t mashb1t approved these changes

@lllyasviel lllyasviel Awaiting requested review from lllyasviel

Assignees
No one assigned
Labels
Size S small change, basically no testing needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rsl8 @mashb1t