Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not close meta tag in HTML header #2740

Merged
merged 2 commits into from
May 17, 2024

Conversation

e52fa787
Copy link
Contributor

One <meta> tag on the main page had an invalid closing </meta> tag, changed it to <meta /> to match the rest of the page.

@mashb1t mashb1t added the Size S small change, basically no testing needed label Apr 25, 2024
as of specification in https://html.com/tags/meta/, meta tagas are null elements:
This element must not contain any content, and does not need a closing tag.
@mashb1t mashb1t changed the base branch from main to develop May 17, 2024 15:24
@mashb1t mashb1t changed the title Fixed typo in HTML (extra </meta> tag) fix: do not close meta tag in HTML header May 17, 2024
@mashb1t mashb1t merged commit 5e59468 into lllyasviel:develop May 17, 2024
@mashb1t mashb1t added this to the 2.4.0 milestone May 17, 2024
csokun pushed a commit to csokun/Fooocus that referenced this pull request Jun 16, 2024
* fixed typo in HTML (extra </meta> tag)

* refactor: remove closing slash for meta tag

as of specification in https://html.com/tags/meta/, meta tagas are null elements:
This element must not contain any content, and does not need a closing tag.

---------

Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size S small change, basically no testing needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants