feat: build and push container image for ghcr.io, update docker.md, and other related fixes #2805

xynydev · 2024-04-24T18:59:53Z

I had some issues with the container and wanted to contrib the fixes back upstream. This has been tested to work on Fedora 39 and in GitHub Actions. Publishing an image on ghcr.io has no extra cost to you as the maintainer, but will make the life of users who prefer containers much easier.

See commits for more details. I'm also happy to answer questions.

…ile:

…or podman and docker

mashb1t · 2024-04-24T19:51:54Z

Hey @xynydev, thank you very much for your effort, much appreciated!
The thing is:
The initial Docker MR already included external registry publishing, but only @lllyasviel can add secrets to this repository, and as he hasn't responded since we've added Docker support we'd need him to set Secrets up in the first place...
So we're currently stuck here.

xynydev · 2024-04-26T05:02:32Z

Hey @mashb1t, this PR doesn't require repository secrets, because it pushes to the GitHub Container Repository (ghcr), which every repository with GitHub Actions has access to by default, using the GitHub token the workflow is run with.

.github/workflows/build_container.yml

entrypoint.sh

docker.md

mashb1t · 2024-05-21T22:47:49Z

Hey @xynydev, I've actually never worked with Github actions to ghcr.io before, so thanks a lot for the explanation.
The goal is only to build an image on releases tagged with versions (semver conform) and I'll have to do the switch from X.X.X to vX.X.X scheme to better distinguish version tags from other ones.
Please double-check the changes.

Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com>

…pt2) Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com>

Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com>

xynydev · 2024-05-22T15:41:32Z

The goal is only to build an image on releases tagged with versions (semver conform) and I'll have to do the switch from X.X.X to vX.X.X scheme to better distinguish version tags from other ones.
Please double-check the changes.

Sounds great. I went ahead and merged your changes. I haven't used the semver option in the docker metadata action, but your suggestion looks alright. I'll see if I can do testing in my repo to validate that it works.

xynydev · 2024-05-22T16:09:30Z

Aight, it worked:
https://github.com/xynydev/Fooocus-fork/actions/runs/9194578288/job/25288353110
https://github.com/xynydev/Fooocus-fork/pkgs/container/fooocus-fork

The tag is 2.3.1 not v2.3.1, though. It might be possible to override that somehow, but everything works well enough now I guess.

Note that the current on: push: condition will only create a new container image when a new tag is created with a new commit in it. This would probably mean that the previous versions wouldn't get container images, only the next one. Also, if anyone has a reason to use an older image, they will get the one that was built that one time, without any fixes that might have been made upstream or in Fooocus' Dockerfile.

mashb1t · 2024-05-22T16:21:17Z

@xynydev thanks for testing, much appreciated!
Tagging in docker with 2.3.1 is expected, git tag has to be v2.3.1 though.

Also, if anyone has a reason to use an older image, they will get the one that was built that one time, without any fixes that might have been made upstream or in Fooocus' Dockerfile.

This is also expected.
Older images are not necessarily planned to be built, first one is the upcoming 2.4.0.
Do you know if a tag on an existing commit will also trigger the pipeline? (this would be the preferred behavior)

xynydev · 2024-05-22T17:22:37Z

From my testing, I'm not sure. I first created a tag on an existing commit and nothing happened. I then made a meaningles commit, pushed it, tagged it locally, and pushed the tag, and then it was triggered.

mashb1t · 2024-05-22T18:59:38Z

@xynydev just tested, the tag has to be on a branch where this change is already included, see https://github.com/mashb1t/Fooocus/actions/runs/9196855992/job/25296038248
Tagging and building older versions is consequently not possible, but also not needed.

mashb1t · 2024-05-22T20:15:03Z

I assume this is a personal issue but I'm getting this error with driver 555.85:
RuntimeError: Unexpected error from cudaGetDeviceCount(). Did you run some cuda functions before calling NumCudaDevices() that might have already set an error? Error 500: named symbol not found

May i ask which driver you're using?
EDIT nvm, works with driver 552.44. Docker may need to add support for the latest driver.

…nd other related fixes (lllyasviel#2805) * chore: update cuda version in container * fix: use symlink to fix error libcuda.so: cannot open shared object file: * fix: update docker entrypoint to use entry_with_update.py * feat: add container build & push workflow * fix: container action run conditions * fix: container action versions * fix: container action versions v2 * fix: docker action registry login and metadata * docs: adjust docker documentation based on latest changes, add docs for podman and docker * chore: replace image name env var with github.event.repository.name Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com> * chore: replace image name env var with github.event.repository.name (pt2) Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com> * fix: switch to semver versioning Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com> * fix: build only on versioned tags Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com> * fix: don't update in entrypoint Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com> * fix: remove dash in "docker-compose" Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com> * feat: sync pytorch for docker with version used in prepare_environment * feat: update cuda to 12.4.1 * fix: correctly clone checked out version in builds, not always main * refactor: remove irrelevant version in docker-compose.yml --------- Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com> Co-authored-by: Manuel Schmid <dev@mash1t.de>

xynydev added 9 commits April 24, 2024 21:00

chore: update cuda version in container

34d432c

fix: use symlink to fix error libcuda.so: cannot open shared object f…

13416a9

…ile:

fix: update docker entrypoint to use entry_with_update.py

33d3df7

feat: add container build & push workflow

a6a71fe

fix: container action run conditions

21bea9a

fix: container action versions

1fb78e5

fix: container action versions v2

7066892

fix: docker action registry login and metadata

e0a4222

docs: adjust docker documentation based on latest changes, add docs f…

37662ae

…or podman and docker

xynydev requested a review from lllyasviel as a code owner April 24, 2024 18:59

mashb1t added Size M medium change, isolated, testing with care documentation Improvements or additions to documentation labels Apr 25, 2024

mashb1t requested changes May 21, 2024

View reviewed changes

mashb1t added this to the 2.4.0 milestone May 21, 2024

xynydev and others added 6 commits May 22, 2024 15:37

chore: replace image name env var with github.event.repository.name

7efa300

Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com>

chore: replace image name env var with github.event.repository.name (…

40711b7

…pt2) Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com>

fix: switch to semver versioning

a80834f

Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com>

fix: build only on versioned tags

d4e373b

Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com>

fix: don't update in entrypoint

ca56194

Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com>

fix: remove dash in "docker-compose"

299ba4d

Co-authored-by: Manuel Schmid <9307310+mashb1t@users.noreply.github.com>

mashb1t added a commit to mashb1t/Fooocus that referenced this pull request May 22, 2024

wip: test lllyasviel#2805

f848309

mashb1t added 4 commits May 22, 2024 23:50

feat: sync pytorch for docker with version used in prepare_environment

7f6dfe2

feat: update cuda to 12.4.1

260193e

fix: correctly clone checked out version in builds, not always main

1b1c3aa

refactor: remove irrelevant version in docker-compose.yml

1ab1b52

mashb1t approved these changes May 22, 2024

View reviewed changes

mashb1t changed the base branch from main to develop May 22, 2024 22:19

mashb1t merged commit 4da5a68 into lllyasviel:develop May 22, 2024

xynydev deleted the container-updates branch May 23, 2024 13:27

mashb1t mentioned this pull request May 27, 2024

feat: build docker image tagged "edge" on push to main branch #3026

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: build and push container image for ghcr.io, update docker.md, and other related fixes #2805

feat: build and push container image for ghcr.io, update docker.md, and other related fixes #2805

xynydev commented Apr 24, 2024 •

edited

Loading

mashb1t commented Apr 24, 2024 •

edited

Loading

xynydev commented Apr 26, 2024

mashb1t commented May 21, 2024

xynydev commented May 22, 2024

xynydev commented May 22, 2024

mashb1t commented May 22, 2024

xynydev commented May 22, 2024

mashb1t commented May 22, 2024

mashb1t commented May 22, 2024 •

edited

Loading

feat: build and push container image for ghcr.io, update docker.md, and other related fixes #2805

feat: build and push container image for ghcr.io, update docker.md, and other related fixes #2805

Conversation

xynydev commented Apr 24, 2024 • edited Loading

mashb1t commented Apr 24, 2024 • edited Loading

xynydev commented Apr 26, 2024

mashb1t commented May 21, 2024

xynydev commented May 22, 2024

xynydev commented May 22, 2024

mashb1t commented May 22, 2024

xynydev commented May 22, 2024

mashb1t commented May 22, 2024

mashb1t commented May 22, 2024 • edited Loading

xynydev commented Apr 24, 2024 •

edited

Loading

mashb1t commented Apr 24, 2024 •

edited

Loading

mashb1t commented May 22, 2024 •

edited

Loading