Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyyaml to 6.0.1 #2927

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update pyyaml to 6.0.1 #2927

wants to merge 2 commits into from

Conversation

cootshk
Copy link

@cootshk cootshk commented May 15, 2024

Adds python 3.11 support. See yaml/pyyaml@6.0...6.0.1

Adds python 3.11 support. See yaml/pyyaml@6.0...6.0.1
@cootshk cootshk requested a review from lllyasviel as a code owner May 15, 2024 20:59
@mashb1t
Copy link
Collaborator

mashb1t commented May 16, 2024

@cootshk is this the only package you noticed for Fooocus to be compatible with Python 3.11?

@cootshk
Copy link
Author

cootshk commented May 16, 2024

@mashb1t I updated all of the packages I needed to update for the project to run (MacOS, python 3.11.4 venv)

Testing on a newly created venv right now

@cootshk
Copy link
Author

cootshk commented May 16, 2024

Seems to work in a new virtual environment from my small amount of testing (also it should work with python 3.12 if you compile scipy)

@mashb1t
Copy link
Collaborator

mashb1t commented May 17, 2024

related to the python 3.12 compatibility issue: #2938

reminder @ self for adding a hint when releasing milestone https://github.com/lllyasviel/Fooocus/milestone/4:
for anyone else reading this who is using the zip file:
run ..\python_embeded\python.exe -m pip install -r .\requirements_versions.txt from within the Fooocus folder to upgrade the packages.

@mashb1t mashb1t added this to the package updates milestone May 17, 2024
@mashb1t mashb1t added the Size M medium change, isolated, testing with care label May 17, 2024
@blckbx
Copy link

blckbx commented May 18, 2024

@cootshk

Pillow=10.0.0

For Python 3.12 compatibility, Pillow needs to be upped to minimum version 10.0.0 (tested on Ubuntu 24.04). transformers may be strictly pinned to 4.40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size M medium change, isolated, testing with care
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants