Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let gallery start in preview mode [video] #2936

Closed
wants to merge 1 commit into from

Conversation

MohammadAboulEla
Copy link

Gallery will start in preview mode, which shows all of the images as thumbnails and allows the user to click on them to view them in full size, this will be the logical option when user generate 1 image at time so the generated image will not be minimized for no reason after being generated. when generated multiple images and since the user will activate it any way to see his images it is also logical to activate it after images being generated.
see attached video
https://github.com/lllyasviel/Fooocus/assets/89942942/397d8d39-0f80-4f84-92fb-a4d1b220047c

Gallery will start in preview mode, which shows all of the images as thumbnails and allows the user to click on them to view them in full size, this will be the logical option when user generate 1 image at time so the generated image will not be minimized for no reason after being generated.  when generated multiple images and since the user will activate it any way to see his images it is also logical to activate it after images being generated.
@mashb1t
Copy link
Collaborator

mashb1t commented May 17, 2024

Hey @MohammadAboulEla,
thank you for your contribution. This is a subjective topic, in my opinion from a user flow perspective the user should start with large previews to better be able to select the generated images, then go into detaill and see even more. This is also aligned with the intermediate image gallery output while generating (on the right of the preview image).
It is absolutely valid to keep the preview in your fork and to have a different opinion about it, but for now it's a "won't change".

@mashb1t mashb1t closed this May 17, 2024
@MohammadAboulEla MohammadAboulEla deleted the patch-1 branch May 19, 2024 14:10
@MohammadAboulEla
Copy link
Author

@mashb1t can't we at least set it to true if batch size = 1, it is annoying to keep clicking the image after being generated

@mashb1t
Copy link
Collaborator

mashb1t commented Jun 7, 2024

@MohammadAboulEla as this is a setting on the gallery element itself it would be global or needs to be updated on every generation, which would not be consistent then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants