Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add clip skip handling #2999

Merged
merged 1 commit into from
May 26, 2024
Merged

feat: add clip skip handling #2999

merged 1 commit into from
May 26, 2024

Conversation

mashb1t
Copy link
Collaborator

@mashb1t mashb1t commented May 26, 2024

Inspired by https://github.com/MoonRide303/Fooocus-MRE/blob/e4415d1d983ffaaeeaacdc23489a335c078641fe/modules/default_pipeline.py#L197-L203

includes

  • metadata handling (when set > 1)
  • history log (when set > 1)
  • preset switching
  • fallback to default config value

Civitai.com handling:
image

@mashb1t mashb1t added this to the 2.4.0 milestone May 26, 2024
@mashb1t mashb1t merged commit cc58fe5 into lllyasviel:develop May 26, 2024
mashb1t added a commit to mashb1t/Fooocus that referenced this pull request May 26, 2024
@mashb1t
Revert "feat: add clip skip handling (lllyasviel#2999)"
6ae87de 
This reverts commit cc58fe5.
mashb1t added a commit that referenced this pull request May 26, 2024
@mashb1t
Revert "feat: add clip skip handling (#2999)" (#3008)
989a1ad 
This reverts commit cc58fe5.
mashb1t added a commit to mashb1t/Fooocus that referenced this pull request May 26, 2024
@mashb1t
Revert "Revert "feat: add clip skip handling (lllyasviel#2999)" (llly…
3ca627c 
…asviel#3008)"

This reverts commit 989a1ad.
mashb1t added a commit that referenced this pull request May 26, 2024
@mashb1t
fix: adjust clip skip default value from 1 to 2 (#3011)
dfff9b7 
* Revert "Revert "feat: add clip skip handling (#2999)" (#3008)"

This reverts commit 989a1ad.

* feat: use clip skip 2 as default
csokun pushed a commit to csokun/Fooocus that referenced this pull request Jun 16, 2024
@mashb1t @csokun
feat: add clip skip handling (lllyasviel#2999)
fa48e0f
csokun pushed a commit to csokun/Fooocus that referenced this pull request Jun 16, 2024
@mashb1t @csokun
Revert "feat: add clip skip handling (lllyasviel#2999)" (lllyasviel#3008
1e3466a 
)

This reverts commit cc58fe5.
csokun pushed a commit to csokun/Fooocus that referenced this pull request Jun 16, 2024
@mashb1t @csokun
fix: adjust clip skip default value from 1 to 2 (lllyasviel#3011)
6d86a29 
* Revert "Revert "feat: add clip skip handling (lllyasviel#2999)" (lllyasviel#3008)"

This reverts commit 989a1ad.

* feat: use clip skip 2 as default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mashb1t