Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged some MRE features (generate hotkey, generate forever, notification sound) #702

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

MoonRide303
Copy link
Collaborator

Merged some non-intrusive Fooocus-MRE features (generate hotkey, generate forever, notification sound - ported from A1111).

@MoonRide303
Copy link
Collaborator Author

@lllyasviel Please check if it's OK to be merged - set of non-intrusive features ported from A1111:

  • generate hotkey (CTRL+ENTER),
  • generate forever (via context menu available after pressing RMB on Generate button),
  • notification sound (plays notification.ogg or notification.mp3 when generation is finished, if either of those files exists).

@lllyasviel
Copy link
Owner

stop button does not stop generating forever - a bit bad
stop button should work and the "stop generating forever" should be removed to avoid confusing

@lllyasviel
Copy link
Owner

if u do not know how to let python gradio to stop the forever loop at js level, I can take a look later
if u know how then u can just attempt a fix

@MoonRide303
Copy link
Collaborator Author

That's how it originally worked in A1111 (separate starting and stopping single and forever generation), so I just left it this way. But you might be right it could be more intuitive if Stop simply stopped all generation, no matter how it was started. Maybe merge as it is, and then simplify stopping generation in another commit?

@MoonRide303
Copy link
Collaborator Author

@lllyasviel Stopping simplified.

@lllyasviel
Copy link
Owner

can we remove the menu binded to stop button
image
I do not think it is doing anything now

@lllyasviel
Copy link
Owner

also i am not hearing the notification sound.
is it turned off by default?

@MoonRide303
Copy link
Collaborator Author

@lllyasviel Yes, by default it's not played - I provided example notification file as notification-example.ogg, but it would have to copied to notification.ogg to be played (or mp3 file named notification.mp3 - it will work, too). I use it for myself, but it could be too strong / distractive for others, so I didn't enable it by default.

@MoonRide303
Copy link
Collaborator Author

And context menu removed from stop button - you're right it didn't make much sense.

@lllyasviel
Copy link
Owner

cool, then add version by 1, and merge yourself after that.
Also, the next time you do not need to notify me if major diffusion algorithm and major UI are not changed.

@MoonRide303 MoonRide303 merged commit 3dd11cf into lllyasviel:main Oct 16, 2023
@MoonRide303 MoonRide303 deleted the mre-features-merge-1 branch October 16, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants