Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magma interface implementation in hiopLinSolver.hpp #43

Closed
pelesh opened this issue Jun 7, 2020 · 2 comments
Closed

Magma interface implementation in hiopLinSolver.hpp #43

pelesh opened this issue Jun 7, 2020 · 2 comments

Comments

@pelesh
Copy link
Collaborator

pelesh commented Jun 7, 2020

Magma solver interface is implemented in hiopLinSolver.hpp what seems to pollute HiOp API. One consequence of that is that any application depending on HiOp will depend on Magma API and will need Magma include files to build (if HiOp is built with Magma). Perhaps it would be good idea to move the implementation of Magma interface to a separate compilation unit (a *.cpp file)?

@cnpetra @ashermancinelli
@cnpetra
Copy link
Collaborator

cnpetra commented Jun 8, 2020

on my todo list

@pelesh pelesh mentioned this issue Jul 15, 2020
Closed
@cnpetra
Copy link
Collaborator

cnpetra commented Jul 29, 2020

addressed by PR#51

@cnpetra cnpetra closed this as completed Jul 29, 2020
ashermancinelli pushed a commit that referenced this issue Jun 22, 2021
@abhyshr
Parse gen fuel types from MATPOWER data file. Closes #43.
3f27c3c
ashermancinelli pushed a commit that referenced this issue Jun 22, 2021
Merge branch 'parse-gen-types' into 'master'
898b7a2 
Parse gen fuel types from MATPOWER data file. Closes #43.

Closes #43

See merge request exasgd/frameworks/scopflow!19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cnpetra @pelesh