New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#164) Replace the combination of IsNot and Matches with Mismatches #233
(#164) Replace the combination of IsNot and Matches with Mismatches #233
Conversation
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
=========================================
Coverage 98.91% 98.91%
Complexity 147 147
=========================================
Files 28 28
Lines 370 370
Branches 7 7
=========================================
Hits 366 366
Misses 4 4 Continue to review full report at Codecov.
|
@baudoliver7 could you fix the conflict, and also you either need to delete the todo, if all is done, or replace it with a new one if there is more work to do. |
ad4e7c6
to
d8d430f
Compare
@victornoel Conflicts resolved. All is done also in the todo. So, I removed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baudoliver7 thank you, here is some review comments :)
src/test/java/org/llorllale/cactoos/matchers/RunsInThreadsTest.java
Outdated
Show resolved
Hide resolved
d8d430f
to
267f3a4
Compare
@baudoliver7 thx |
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 8min) |
Job |
#164