Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#164) Replace the combination of IsNot and Matches with Mismatches #233

Merged
merged 1 commit into from Feb 22, 2021

Conversation

baudoliver7
Copy link
Contributor

#164

  • Replace this combination in each test case where it was found

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #233 (267f3a4) into master (dfcfa64) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #233   +/-   ##
=========================================
  Coverage     98.91%   98.91%           
  Complexity      147      147           
=========================================
  Files            28       28           
  Lines           370      370           
  Branches          7        7           
=========================================
  Hits            366      366           
  Misses            4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfcfa64...267f3a4. Read the comment docs.

@0crat
Copy link
Collaborator

0crat commented Feb 16, 2021

@victornoel/z everybody who has role REV is banned at #233; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@victornoel
Copy link
Collaborator

victornoel commented Feb 20, 2021

@baudoliver7 could you fix the conflict, and also you either need to delete the todo, if all is done, or replace it with a new one if there is more work to do.

@0crat
Copy link
Collaborator

0crat commented Feb 21, 2021

@victornoel/z everybody who has role REV is banned at #233; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@baudoliver7
Copy link
Contributor Author

@victornoel Conflicts resolved. All is done also in the todo. So, I removed it.

Copy link
Collaborator

@victornoel victornoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baudoliver7 thank you, here is some review comments :)

@victornoel
Copy link
Collaborator

@baudoliver7 thx

@victornoel
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 22, 2021

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 267f3a4 into llorllale:master Feb 22, 2021
@rultor
Copy link
Collaborator

rultor commented Feb 22, 2021

@rultor merge

@victornoel Done! FYI, the full log is here (took me 8min)

@baudoliver7 baudoliver7 deleted the replace_combination_of_isnot branch February 22, 2021 11:54
@0crat
Copy link
Collaborator

0crat commented Feb 22, 2021

Job gh:llorllale/cactoos-matchers#233 is not assigned, can't get performer

@0crat 0crat removed the 0crat/scope label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants