Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#83) Run on various Java version + latest codecov-action #237

Merged
merged 1 commit into from Mar 14, 2021

Conversation

victornoel
Copy link
Collaborator

Run on various Java version + latest codecov-action

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #237 (bf999ca) into master (267f3a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #237   +/-   ##
=========================================
  Coverage     98.91%   98.91%           
  Complexity      147      147           
=========================================
  Files            28       28           
  Lines           370      370           
  Branches          7        7           
=========================================
  Hits            366      366           
  Misses            4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267f3a4...bf999ca. Read the comment docs.

@victornoel
Copy link
Collaborator Author

@llorllale could it be possible to change the project configuration to match with this new CI workflow? It seems the two "Tests (macOS-10.15)" and "Tests (ubuntu-18.04)" required checks are not the correct ones :)

@llorllale
Copy link
Owner

@victornoel done

@victornoel
Copy link
Collaborator Author

@llorllale thx a lot :)

@victornoel
Copy link
Collaborator Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Mar 14, 2021

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit bf999ca into llorllale:master Mar 14, 2021
@rultor
Copy link
Collaborator

rultor commented Mar 14, 2021

@rultor merge

@victornoel Done! FYI, the full log is here (took me 7min)

@victornoel victornoel deleted the ci branch March 14, 2021 16:22
@0crat
Copy link
Collaborator

0crat commented Mar 14, 2021

Job was finished in 5 hours, bonus for fast delivery is possible (see §36)

@0crat 0crat added qa and removed 0crat/scope labels Mar 14, 2021
@0crat
Copy link
Collaborator

0crat commented Mar 14, 2021

@sereshqua/z please review this job completed by @baudoliver7/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@sereshqua
Copy link

@0crat quality bad

@0crat 0crat added quality/bad and removed qa labels Mar 14, 2021
@0crat
Copy link
Collaborator

0crat commented Mar 14, 2021

Quality is low, no payment, see §31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants