New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#243: Introduce IsBytes
#244
Conversation
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
============================================
+ Coverage 98.95% 99.00% +0.04%
- Complexity 150 157 +7
============================================
Files 28 29 +1
Lines 383 401 +18
Branches 7 8 +1
============================================
+ Hits 379 397 +18
Misses 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreoss see the comment and also, I don't think it's a good idea to have a bunch of constructors with lots of behaviour (in particular the int
one). Instead let's just take a Bytes
as well as a byte...
and let the user exploit BytesOf
if they need it.
void mismatches() { | ||
new Assertion<>( | ||
"Must mismatch with bytes", | ||
new IsBytes((byte) 65, (byte) 66, (byte) 67), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreoss why do we need to cast here? if this is because of the char... constructor, then let's remove it, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victornoel it's narrowing conversion, casting should be explicit
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 7min) |
Per #243
IsBytes