New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Crashlytics and references to maven.io #18
Conversation
Thanks so much for digging into this! Per the commit that implemented Crashlytics, you'll also need to remove the Also, would you like to be added to the contributors list? If so, what name would you prefer for that? I'll make a separate commit to add you in once the pull request is merged in. |
updated the PR with the new changes, but please do not merge yet, tomorrow I will test more thoroughly
yes, thanks! use "Samtinel" please |
3318d35
to
fb5168a
Compare
It currently doesn't build for me, looks like gradle. will report back. |
Ah, interesting. Apparently Gradle has to be >= 6.3 to work with JDK 14. Downgrading java fixed that. Building works. |
It runs also fine through the smoke test. What I wonder is if in the settings the switch "send crash reports" also needs removal. A first look didn't really tell me what SETTING_CRASHREPORT does. |
Good catch, definitely get rid of that switch while you're at it. |
Removed the toggle and its resources, as well as the mention of CrashLytics in the readme. It compiles and passes the smoke test. |
This pull request LGTM, thanks so much for doing this! We can handle blocking changes related to F-Droid in #17. |
This PR removes Crashlytics and reference to maven.io. This means it is buildable by F-Droid. To be included, metadata has to be added, see #17 .