Handle printing and globals #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
force-pushed
the
rebase3
branch
2 times, most recently
from
abbeb28
to
700015c
Compare
chelini
approved these changes
Nov 5, 2020
| } | ||
| } | ||
| } | ||
| if (auto IC1 = dyn_cast<ImplicitCastExpr>(a)) { |
There was a problem hiding this comment.
This check is the same as the one above (line 559). Can you not move lines 571 to 575 here, and remove the duplicate check?
| LLVM::LLVMType::getFunctionTy(rt, types, | ||
| /*isVarArg=*/FD->isVariadic()); | ||
|
|
||
| // Insert the printf function into the body of the parent module. |
There was a problem hiding this comment.
This function seems generic why in the comment you refer to "printf" only?
| builder.setInsertionPointToStart(module.getBody()); | ||
| return llvmFunctions[FD] = builder.create<LLVM::LLVMFuncOp>(module.getLoc(), | ||
| name, llvmFnType); | ||
| // return llvmFunctions[FD] = SymbolRefAttr::get(name, module.getContext()); |
| std::map<const VarDecl *, mlir::LLVM::GlobalOp> llvmGlobals; | ||
| mlir::LLVM::GlobalOp GetOrCreateLLVMGlobal(const VarDecl *VD); | ||
|
|
||
| /// Return a value representing an access into a global string with the given |
vatai
pushed a commit
that referenced
this pull request
Sep 15, 2023
ivanradanov
pushed a commit
that referenced
this pull request
Nov 3, 2023
ivanradanov
pushed a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.