[HW] [NFC] Extract out printing/parsing functions for modules #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teqdruid
changed the title
|
@lattner I'd like to use the module parsing code in my (future) module ops. Do you have any objections to this? |
lattner
approved these changes
Sep 11, 2021
|
I agree that this probably isn't the best way to layer this, but I also don't know what that way is. There will also be a number of other issues like this coming out of my msft "module/instance-like" ops, so it's probably advisable to get it working with a little mileage on it before we generalize it correctly. |
To enable re-use in other dialects.
teqdruid
force-pushed
the
hw-modulelike-utils
branch
from
0230d89
to
0ded65e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable re-use in other dialects.