[FIRRTL] Add support for multi-bit FIRRTL Memory mask type, NFC #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthscsi
approved these changes
Sep 24, 2021
richardxia
reviewed
Sep 24, 2021
Comment on lines
+1408
to
+1409
| // Mask of zero bits means, either there are no write/readwrite ports or the | ||
| // mask is of aggregate type. |
There was a problem hiding this comment.
This might be good to move into the main documentation comment for the method, since it's an important thing to know about the return value.
There was a problem hiding this comment.
Good idea, a proper documentation for firrtl.mem is missing. I will add it in a subsequent PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to add multi-bit mask type for FIRRTL memories.
This is required for flattening an aggregate memory data type, and enabling a finer mask granularity by extracting individual bits from the memory data element.
The mask bit was hard coded to 1 in several places, this PR will remove that restriction.