Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Run git describe from the source dir, fix out-of-tree builds #3199

Merged
merged 1 commit into from
May 25, 2022

Conversation

dtzSiFive
Copy link
Contributor

@dtzSiFive dtzSiFive commented May 25, 2022

Don't rely on build being same or underneath the source directory.

Fixes #3175.

Don't rely on build being same or underneath the source directory.

Fixes llvm#3175.
Copy link
Contributor

@teqdruid teqdruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtzSiFive dtzSiFive merged commit 9f240a8 into llvm:main May 25, 2022
@dtzSiFive dtzSiFive deleted the fix/issue-3715 branch May 25, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version generation fails for out-of-tree builds
4 participants