Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HW] Fix type casts for nested type alias #5339

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented Jun 8, 2023

This fixes a small bug that alias-aware type casts are not recursively applied.

This fixes a small bug that alias-awaret type casts are not recursively
applied.
@uenoku uenoku requested a review from mikeurbach June 8, 2023 12:48
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, looks like this has been there since the beginning. Thanks for finding it and fixing it. This looks good to me, but it would be great if you don't mind adding tests to ensure this doesn't regress in the future.

@uenoku uenoku force-pushed the dev/uenoku/fix-hw-typecast branch from 8da106f to bcddb2e Compare June 15, 2023 06:45
@uenoku uenoku merged commit 7d745ec into main Jun 15, 2023
5 checks passed
@uenoku uenoku deleted the dev/uenoku/fix-hw-typecast branch June 15, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants