Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Add StringConstantOp #5345

Merged
merged 1 commit into from
Jun 9, 2023
Merged

[FIRRTL] Add StringConstantOp #5345

merged 1 commit into from
Jun 9, 2023

Conversation

youngar
Copy link
Member

@youngar youngar commented Jun 9, 2023

This add an operation to create a constant of string type, as well as a fold to StringAttr and a StringType materializer.

@youngar
[FIRRTL] Add StringConstantOp
84f24e0 
This add an operation to create a constant of string type, as well
as a fold to StringAttr and a StringType materializer.
@youngar youngar added the FIRRTL Involving the `firrtl` dialect label Jun 9, 2023
@youngar youngar merged commit 6928392 into llvm:main Jun 9, 2023
5 checks passed
@youngar youngar deleted the firrtl-string-buildable branch June 9, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwy7 rwy7 rwy7 approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@dtzSiFive dtzSiFive Awaiting requested review from dtzSiFive

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@youngar @rwy7