[FIRRTL] Add property assign op instead of using connect #5361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new statement to FIRRTL to assign a property to a proptery sink. We stop allowing properties to be connected with a ConnectOp. This new operation enforces that the parent operation is a FModuleOp, and that it has static single connects, which is a good limitation to keep from using this operation inside a WhenOp.
rwy7
reviewed
Jun 12, 2023
rwy7
approved these changes
Jun 12, 2023
Co-authored-by: Robert Young <rwy0717@gmail.com>
mikeurbach
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new statement to FIRRTL to assign a property to a property sink. We stop allowing properties to be connected with a ConnectOp. This new operation enforces that the parent operation is a FModuleOp, and that it has static single connects, which is a good limitation to keep from using this operation inside a WhenOp.