[FIRRTL] Improve PropAssignOp verifiers #5375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds verifiers which: 1. check that a source is not a destination. 2. check that a sink if not driven more than once.
dtzSiFive
approved these changes
Jun 13, 2023
| @@ -2531,6 +2531,23 @@ LogicalResult RefDefineOp::verify() { | |||
| return success(); | |||
| } | |||
|
|
|||
| LogicalResult PropAssignOp::verify() { | |||
There was a problem hiding this comment.
Might be good to share code w/RefDefineOp's verifier (modulo blacklisted destination ops, not sure what story is for properties--just remember only-has-one-driver gets a little less trivial to check once aggregates enter the scene, particularly if you're allowed to have "aliasing" sub-accesses to same element (refs don't have this problem, for now anyway 😄).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds verifiers which: