[Pipeline] Add verifiers and fix register materialization pass #5386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortbopet
changed the title
mortbopet
force-pushed
the
dev/mpetersen/latency_upstream
branch
2 times, most recently
from
b31aefe
to
2e6f659
Compare
Adds a bunch more verification to the `pipeline.scheduled` and `pipeline.latency` ops, as well as fixing the register materialization pass. The register materialization pass has now been modified to accomodate arbitrarily nested operations within each stage, which is a superset of the support required for `pipeline.latency`, in case operations in the inner body references values defined outside of its stage.
mortbopet
force-pushed
the
dev/mpetersen/latency_upstream
branch
from
2e6f659
to
a604cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bunch more verification to the
pipeline.scheduledandpipeline.latencyops, as well as fixing the register materialization pass:pipeline.latency, in case operations in the inner body of thepipeline.latencyop references values defined outside of its stage.