PTECH-747: llvm bump on circt. Found 2 errors.

[mbalboni07]

fork for llvm bump on circt

[mbalboni07]

Found 2 errors

/circt/lib/Conversion/ArcToLLVM/LowerArcToLLVM.cpp:329:61:   required from here
circt/llvm/mlir/include/mlir/IR/Builders.h:490:16: error: no matching function for call to 'mlir::llvm::CountLeadingZerosOp::build(mlir::OpBuilder&, mlir::OperationState&, mlir::Type, mlir::Value, mlir::Value&)'
  490 |     OpTy::build(*this, state, std::forward<Args>(args)...);
      |     ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
/circt/lib/Conversion/ArcToLLVM/LowerArcToLLVM.cpp:334:60:   required from here/circt/llvm/mlir/include/mlir/IR/Builders.h:490:16: error: no matching function for call to 'mlir::LLVM::CountTrailingZerosOp::build(mlir::OpBuilder&, mlir::OperationState&, mlir::Type, mlir::Value, mlir::Value&)'
  490 |     OpTy::build(*this, state, std::forward<Args>(args)...);
      |     ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[teqdruid]

Do you need this specific llvm submodule to not encounter those compile issues? IIRC we haven't seen our weekly bump to latest yet this week.

What compiler/version/OS are you using? We aren't catching this in our CI.

[teqdruid]

nevermind... this IS the weekly bump.

[mikeurbach]

@fabianschuiki @maerhart seems some LLVM op builders used by arc have changed?

[fabianschuiki]

LGTM! Thanks for tackling this 👍

It looks like FlattenMemRefs.cpp is using things in the control flow dialect. Maybe the CMakeLists.txt for CIRCTTransforms needs a dependency on MLIRCF?