-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PTECH-747: llvm bump on circt. Found 2 errors. #5414
PTECH-747: llvm bump on circt. Found 2 errors. #5414
Conversation
Found 2 errors
|
Do you need this specific llvm submodule to not encounter those compile issues? IIRC we haven't seen our weekly bump to latest yet this week. What compiler/version/OS are you using? We aren't catching this in our CI. |
nevermind... this IS the weekly bump. |
@fabianschuiki @maerhart seems some LLVM op builders used by arc have changed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for tackling this 👍
It looks like FlattenMemRefs.cpp
is using things in the control flow dialect. Maybe the CMakeLists.txt
for CIRCTTransforms
needs a dependency on MLIRCF
?
fork for llvm bump on circt