[FIRRTL] Add FIRRTLTypeSwitch #5456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds minimal changes BaseTypeAliasType for base type alias. Implement storage and methods for FIRRTLBaseType and FieldIDTypeInterface. This doesn't include recursive property chagnes and `FIRRTLBaseType::getAnonnymousType` whcih requires more broader changes.
This implements `type_isa/type_cast/type_dyn_cast/type_dyn_cast_or_null`. When a given type is an alias, these casts will visit its inner type recursively. These type casts can be used anywhere and if the requested type is non-base type or FIRRTLBaseType itself, then it will optimized in the compile time,
Co-authored-by: Prithayan Barua <prithayan@gmail.com>
calebmkim
pushed a commit
to andrewb1999/circt
that referenced
this pull request
Jul 12, 2023
This PR implements FIRRTLTypeSwitch which extends TypeSwitch so that we can use firrtl::type_{cast, dyn_cast, isa} when matching types. Currently llvm::TypeSwitch is not extensible so the code is duplicated to FIRRTLTypes.h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements FIRRTLTypeSwitch which extends TypeSwitch so that we can use
firrtl::type_{cast, dyn_cast, isa}when matching types. Currently llvm::TypeSwitch is not extensible so the code is duplicated to FIRRTLTypes.h.