Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LowerFIRRTLToHW] Use backedges over temporary wires, NFC #5513

Merged
merged 2 commits into from
Jun 28, 2023
Merged

[LowerFIRRTLToHW] Use backedges over temporary wires, NFC #5513

merged 2 commits into from
Jun 28, 2023

Commits on Jun 28, 2023

  1. [LowerFIRRTLToHW] Use backedges over temporary wires, NFC 

    This changes LowerFIRRTLToHW to use backedges instead of temporary wire
operations. The temporary wires were guaranteed to be optimized away.
Now we slightly more gracefully handle the, technically illegal, cases
of these wires having no value driven to them.  This change is NFC in
the FIRRTL pipeline where these invariants have already been verified.
We can remove the infrastructure for creating these temporary wires, as
there are now more uses.
    @youngar
    youngar committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    8936358 View commit details
    Browse the repository at this point in the history

  2. [LowerFIRRTLToHW] Remove redundant check 

    Foreign typed ports can never be considered an InOut port, so they can
be handled by the code path which checks if the port is an input port,
which is handled identically.
    @youngar
    youngar committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    c4f3ff2 View commit details
    Browse the repository at this point in the history