[LowerFIRRTLToHW] Use backedges over temporary wires, NFC #5513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a follow up from #5510. |
dtzSiFive
reviewed
Jun 28, 2023
This changes LowerFIRRTLToHW to use backedges instead of temporary wire operations. The temporary wires were guaranteed to be optimized away. Now we slightly more gracefully handle the, technically illegal, cases of these wires having no value driven to them. This change is NFC in the FIRRTL pipeline where these invariants have already been verified. We can remove the infrastructure for creating these temporary wires, as there are now more uses.
youngar
force-pushed
the
firrt-lower-less-wires
branch
from
2102bd7
to
8936358
Compare
Foreign typed ports can never be considered an InOut port, so they can be handled by the code path which checks if the port is an input port, which is handled identically.
calebmkim
pushed a commit
to andrewb1999/circt
that referenced
this pull request
Jul 12, 2023
This changes LowerFIRRTLToHW to use backedges instead of temporary wire operations. The temporary wires were guaranteed to be optimized away. Now we slightly more gracefully handle the, technically illegal, cases of these wires having no value driven to them. This change is NFC in the FIRRTL pipeline where these invariants have already been verified. We can remove the infrastructure for creating these temporary wires, as it is not used anymore. Foreign typed ports can never be considered an InOut port, so they can be handled by the code path which checks if the port is an input port, which is handled identically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes LowerFIRRTLToHW to use backedges instead of temporary wire operations. The temporary wires were guaranteed to be optimized away. Now we slightly more gracefully handle the, technically illegal, cases of these wires having no value driven to them. This change is NFC in the FIRRTL pipeline where these invariants have already been verified. We can remove the infrastructure for creating these temporary wires, as it is not used anymore.