Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Delete force/release statements with constant-false predicates. #5555

Merged
merged 1 commit into from
Jul 10, 2023
Merged

[FIRRTL] Delete force/release statements with constant-false predicates. #5555

merged 1 commit into from
Jul 10, 2023

Conversation

dtzSiFive
Copy link
Contributor

Fixes #5003.

@dtzSiFive dtzSiFive force-pushed the feature/canon-pred-false-force-release branch from aaa7d8c to 882299f Compare July 7, 2023 20:34
@dtzSiFive dtzSiFive added the FIRRTL Involving the `firrtl` dialect label Jul 7, 2023
uenoku
uenoku approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dtzSiFive
Copy link
Contributor Author

Thanks!

@dtzSiFive dtzSiFive merged commit 87aa42f into llvm:main Jul 10, 2023
5 checks passed
@dtzSiFive dtzSiFive deleted the feature/canon-pred-false-force-release branch July 10, 2023 13:57
calebmkim pushed a commit to andrewb1999/circt that referenced this pull request Jul 12, 2023
@dtzSiFive @calebmkim
[FIRRTL] Delete force/release statements with constant-false predicat…
33898ba 
…es. (llvm#5555)

Fixes llvm#5003.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uenoku uenoku uenoku approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIRRTL] Add canonicalizer to erase force/release with constant-false predicate
2 participants
@dtzSiFive @uenoku