Fix ordering of operands in ScheduledPipelineOp::build #5585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teqdruid
approved these changes
Jul 13, 2023
lib/Dialect/Pipeline/PipelineOps.cpp
Outdated
| odsState.addOperands(go); | ||
| odsState.addOperands(clock); | ||
| odsState.addOperands(reset); | ||
|
|
There was a problem hiding this comment.
nit: I would prefer no newlines here.
teqdruid
reviewed
Jul 14, 2023
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| // CHECK-LABEL: hw.module @pipeline( | |||
| // CHECK-SAME: %[[VAL_0:.*]]: i32, %[[VAL_1:.*]]: i32, %[[VAL_2:.*]]: i1, %[[VAL_3:.*]]: i1, %[[VAL_4:.*]]: i1) -> (out: i32) { | |||
| // CHECK: %[[VAL_5:.*]], %[[VAL_6:.*]] = pipeline.scheduled(%[[VAL_7:.*]] : i32 = %[[VAL_0]], %[[VAL_8:.*]] : i32 = %[[VAL_1]]) clock(%[[VAL_9:.*]] = %[[VAL_2]]) reset(%[[VAL_10:.*]] = %[[VAL_3]]) go(%[[VAL_11:.*]] = %[[VAL_4]]) -> (out : i32) { | |||
| // CHECK: %[[VAL_5:.*]], %[[VAL_6:.*]] = pipeline.scheduled(%[[VAL_7:.*]] : i32 = %[[VAL_0]], %[[VAL_8:.*]] : i32 = %[[VAL_1]]) clock(%[[VAL_9:.*]] = %[[VAL_3]]) reset(%[[VAL_10:.*]] = %[[VAL_4]]) go(%[[VAL_11:.*]] = %[[VAL_2]]) -> (out : i32) { | |||
There was a problem hiding this comment.
Why was this change necessary? This implies that this particular builder was being used by the parser.
There was a problem hiding this comment.
The builder is used in the scheduling pass, hence when the result was being printed, operands were printed in the wrong order. If i (or the reviewers) of this had been a bit more attentive, we'd have spotted this issue there.
mortbopet
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #5584.
ScheduledPipelineOp::buildis changed to add operands in the same order thatPipelineOps.tdexpects.