-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Calyx] Add Repeat Op #5606
[Calyx] Add Repeat Op #5606
Conversation
Agh, the count is still static for a dynamic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable to me.
@@ -145,7 +145,7 @@ PortInfo calyx::getPortInfo(BlockArgument arg) { | |||
|
|||
/// Returns whether the given operation has a control region. | |||
static bool hasControlRegion(Operation *op) { | |||
return isa<ControlOp, SeqOp, IfOp, WhileOp, ParOp, StaticRepeatOp, | |||
return isa<ControlOp, SeqOp, IfOp, RepeatOp, WhileOp, ParOp, StaticRepeatOp, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not something to change in this PR, but these isa
checks should probably check if op is ControlLike.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Ok, merging |
We recently added a non-static repeat op to native Calyx.
This PR adds it to the CIRCT Calyx Dialect. It was pretty straightforward, given we had already added a
static repeat
.Dynamic
repeat
statement work the same as static repeat statements, except the body can be dynamically timed.