[Calyx] Add Repeat Op #5606
Merged
[Calyx] Add Repeat Op #5606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgyurgyik
reviewed
Jul 17, 2023
|
Agh, the count is still static for a dynamic |
cgyurgyik
reviewed
Jul 17, 2023
mikeurbach
approved these changes
Jul 17, 2023
| @@ -145,7 +145,7 @@ PortInfo calyx::getPortInfo(BlockArgument arg) { | |||
|
|
|||
| /// Returns whether the given operation has a control region. | |||
| static bool hasControlRegion(Operation *op) { | |||
| return isa<ControlOp, SeqOp, IfOp, WhileOp, ParOp, StaticRepeatOp, | |||
| return isa<ControlOp, SeqOp, IfOp, RepeatOp, WhileOp, ParOp, StaticRepeatOp, | |||
There was a problem hiding this comment.
Not something to change in this PR, but these isa checks should probably check if op is ControlLike.
|
Ok, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added a non-static repeat op to native Calyx.
This PR adds it to the CIRCT Calyx Dialect. It was pretty straightforward, given we had already added a
static repeat.Dynamic
repeatstatement work the same as static repeat statements, except the body can be dynamically timed.