Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ibis] Structural basics: classes, functions, and calls #5646

Merged
merged 6 commits into from
Jul 24, 2023
Merged

[Ibis] Structural basics: classes, functions, and calls #5646

merged 6 commits into from
Jul 24, 2023

Conversation

teqdruid
Copy link
Contributor

No description provided.

@teqdruid teqdruid added the Ibis label Jul 21, 2023
mortbopet
mortbopet reviewed Jul 21, 2023
View reviewed changes
Copy link
Contributor

@mortbopet mortbopet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also add a test for a function with no return types, and with no ibis.return in the body to sanity check the implicit terminator stuff.

lib/Dialect/Ibis/IbisOps.cpp Outdated Show resolved Hide resolved
test/Dialect/Ibis/structure.mlir Outdated Show resolved Hide resolved
@teqdruid teqdruid merged commit 0d344df into main Jul 24, 2023
5 checks passed
@teqdruid teqdruid deleted the dev/teqdruid/ibis/ops branch July 24, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakep-msft blakep-msft blakep-msft approved these changes

@mortbopet mortbopet Awaiting requested review from mortbopet mortbopet is a code owner

Assignees
No one assigned
Labels
Ibis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teqdruid @mortbopet @blakep-msft