[FIRRTL] Add Groups to LowerTypes #5649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
force-pushed
the
dev/seldridge/firrtl-groups-expand-whens
branch
from
d0263e7
to
ed8a5de
Compare
seldridge
force-pushed
the
dev/seldridge/firrtl-groups-lower-types
branch
from
0cd6091
to
a61316e
Compare
seldridge
force-pushed
the
dev/seldridge/firrtl-groups-expand-whens
branch
from
ed8a5de
to
b29590b
Compare
seldridge
force-pushed
the
dev/seldridge/firrtl-groups-lower-types
branch
from
a61316e
to
3ad3163
Compare
seldridge
force-pushed
the
dev/seldridge/firrtl-groups-expand-whens
branch
from
b29590b
to
bb16256
Compare
seldridge
force-pushed
the
dev/seldridge/firrtl-groups-lower-types
branch
2 times, most recently
from
591d48b
to
7d4ca23
Compare
seldridge
force-pushed
the
dev/seldridge/firrtl-groups-expand-whens
branch
from
bb16256
to
279b645
Compare
Update the LowerTypes pass to support lowering aggregate declarations inside group definitions. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
force-pushed
the
dev/seldridge/firrtl-groups-lower-types
branch
from
7d4ca23
to
44fa16e
Compare
seldridge
force-pushed
the
dev/seldridge/firrtl-groups-expand-whens
branch
from
279b645
to
5b1e1be
Compare
seldridge
changed the base branch from
dev/seldridge/firrtl-groups-expand-whens
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the LowerTypes pass to support lowering aggregate declarations inside group definitions.