[DC] Add cast to/from ESI ops #5676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortbopet
commented
Jul 25, 2023
mortbopet
force-pushed
the
dev/mpetersen/dc_esi
branch
from
bc96cd6
to
8949fa2
Compare
teqdruid
reviewed
Jul 25, 2023
|
What is the rationale for |
Much needed cast operations to/from ESI. Given that `dc.value`s have unnamed fields (which i think is a good descision) `dc.value`s with multiple types will be converted to a `hw.struct` with an inferred name, in this case `field#`. In most cases, this won't be compatible with the structs used in an input/output ESI channel. To address this, source materializations (esi -> dc) are automatically handled by an inserted `hw.bitcast`. Target materializations (and result type inference, dc -> esi) can be directed by specifying a forced type in the `dc.to_esi` op.
mortbopet
force-pushed
the
dev/mpetersen/dc_esi
branch
from
8949fa2
to
ec69c84
Compare
|
With the simplification of |
teqdruid
reviewed
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much needed cast operations to/from ESI.
Given that
dc.values have unnamed fields (which i think is a good descision)dc.values with multiple types will be converted to ahw.structwith an inferred name, in this casefield#. In most cases, this won't be compatible with the structs used in an input/output ESI channel. To address this, source materializations (esi -> dc) are automatically handled by an insertedhw.bitcast. Target materializations (and result type inference, dc -> esi) can be directed by specifying a forced type in thedc.to_esiop.