Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DC] dc.value should only take one type #5702

Merged
merged 2 commits into from
Jul 28, 2023
Merged

[DC] dc.value should only take one type #5702

merged 2 commits into from
Jul 28, 2023

Conversation

mortbopet
Copy link
Contributor

  • accepting multiple types is data semantics encroaching the control-only land of DC.

@mortbopet
[DC] dc.value should only take one type
d6f6561 
- accepting multiple types is data semantics encroaching the control-only land of DC.
teqdruid
teqdruid approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@teqdruid teqdruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels much better!

@mortbopet mortbopet merged commit 57e36b6 into main Jul 28, 2023
5 checks passed
@darthscsi darthscsi deleted the dev/mpetersen/dc_valuetype branch June 4, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teqdruid teqdruid teqdruid approved these changes

@Dinistro Dinistro Awaiting requested review from Dinistro Dinistro is a code owner

@lucas-rami lucas-rami Awaiting requested review from lucas-rami

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mortbopet @teqdruid