[HW] Add InnerSymAttr python bindings #5711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These binding are very shallow and only support the use case of a single InnerSymProperties with a fieldID of 0. Current use cases only require this limited functionality, and in the future we will probably be changing the underlying attributes, so it doens't make sense to expose it all now.
teqdruid
approved these changes
Jul 28, 2023
rwy7
reviewed
Jul 28, 2023
rwy7
approved these changes
Jul 28, 2023
mikeurbach
approved these changes
Jul 28, 2023
|
|
||
| MlirAttribute hwInnerSymAttrGetSymName(MlirAttribute innerSymAttr) { | ||
| return wrap( | ||
| (Attribute)unwrap(innerSymAttr).cast<InnerSymAttr>().getSymName()); |
There was a problem hiding this comment.
Is the cast to (Attribute) necessary?
There was a problem hiding this comment.
Admittedly I just copied this code from elsewhere, but it appears that wrap(StringAttr) returns an MlirIdentifier instead of an MlirAttribute (and it fails to compile).
DEFINE_C_API_METHODS(MlirIdentifier, mlir::StringAttr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These binding are very shallow and only support the use case of a single InnerSymProperties with a fieldID of 0. Current use cases only require this limited functionality, and in the future we will probably be changing the underlying attributes, so it doesn't make sense to expose it all now.