Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[circt-reduce] Add DropNames Preserving None Pass #5713

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

seldridge
Copy link
Member

Add the DropNames pass to circt-reduce with the option to drop all names. This has the benefit of letting canonicalizers/folders go ham. This was observed as a missed opportunity on a recent reduction that left many connections like the following:

node b = a
node c = b
node d = c

Dropping names causes all of these to get folded away and dramatically reduced the final, already very small, reduced design (by 50%).

Add the DropNames pass to circt-reduce with the option to drop all names.
This has the benefit of letting canonicalizers/folders go ham.  This was
observed as a missed opportunity on a recent reduction that left many
connections like the following:

    node b = a
    node c = b
    node d = c

Dropping names causes all of these to get folded away and dramatically
reduced the final, already very small, reduced design (by 50%).

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Copy link
Member

@youngar youngar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@seldridge seldridge merged commit c341de5 into main Jul 28, 2023
5 checks passed
@seldridge seldridge deleted the dev/seldridge/circt-reduce-drop-all-names branch July 28, 2023 14:55
@seldridge seldridge restored the dev/seldridge/circt-reduce-drop-all-names branch July 28, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants