Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Add path types #5735

Merged
merged 4 commits into from
Jul 31, 2023
Merged

[FIRRTL] Add path types #5735

merged 4 commits into from
Jul 31, 2023

Conversation

youngar
Copy link
Member

@youngar youngar commented Jul 31, 2023

No description provided.

@youngar youngar added the FIRRTL Involving the `firrtl` dialect label Jul 31, 2023
seldridge
seldridge approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could you add emitter support or file a tracking issue to add it?

dtzSiFive
dtzSiFive approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Woohoo!

lib/Dialect/FIRRTL/Import/FIRTokenKinds.def Outdated
@@ -127,6 +127,7 @@ TOK_KEYWORD(of)
TOK_KEYWORD(old)
TOK_KEYWORD(output)
TOK_KEYWORD(parameter)
TOK_KEYWORD(Path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this is alpha-sorted case-sensitive, please either change that or put this up with the capitals!

@youngar youngar merged commit 2104dd7 into llvm:main Jul 31, 2023
5 checks passed
@youngar youngar deleted the firrtl-path-type branch July 31, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

@rwy7 rwy7 rwy7 approved these changes

@dtzSiFive dtzSiFive dtzSiFive approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

Assignees
No one assigned
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@youngar @seldridge @rwy7 @dtzSiFive