Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESI][HW][DC][OM][Comb][Ibis] Documentation refactoring and fixes #5767

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

teqdruid
Copy link
Contributor

@teqdruid teqdruid commented Aug 3, 2023

  • Refactors the ESI documentation and adds some content.
  • Makes new HW types work the same way as the old ones.
    • Fixes new HW types appearing in other dialects.
  • Fixes some pointers in the documentation.
  • Adds DC, Comb, OM, and Ibis passes to the passes page.
    • Allows the website publishing processing script to remove them, eliminating the odd empty menu items.

NFC except for the documentation.

- Refactors the ESI documentation.
- Makes new HW types work the same way as the old ones.
  - Fixes new HW types appearing in other dialects.
- Fixes some pointers in the documentation.
- Adds DC, Comb, OM, and Ibis passes to the passes page.
  - Allows the website publishing processing script to remove them,
    eliminating the odd empty menu items.
@teqdruid
Copy link
Contributor Author

teqdruid commented Aug 3, 2023

Most of these changes are an NFC refactor of the ESI ODS files to better organize the tblgen'd docs. But I found some other website issues in the process.

I figured out how to build the website locally so I was able to test these changes... Hopefully the website publishing pipeline agrees.

Copy link
Member

@youngar youngar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing up the pass documentation!

@teqdruid teqdruid merged commit 0fea296 into main Aug 3, 2023
5 checks passed
@teqdruid teqdruid deleted the dev/teqdruid/esi/doc-updates branch August 3, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants