Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] RWProbeOp: Add requirement+verify def before use. #5807

Merged
merged 2 commits into from
Aug 10, 2023
Merged

[FIRRTL] RWProbeOp: Add requirement+verify def before use. #5807

merged 2 commits into from
Aug 10, 2023

Conversation

dtzSiFive
Copy link
Contributor

@dtzSiFive dtzSiFive commented Aug 8, 2023 •
edited
Loading

This mostly matters because our passes like to assume this sort of thing, so explicitly verify it.

@dtzSiFive dtzSiFive requested a review from youngar August 8, 2023 18:43
@dtzSiFive dtzSiFive marked this pull request as ready for review August 8, 2023 21:38
@dtzSiFive
Copy link
Contributor Author

We can generalize this re:some notion of local-only refs/syms next.

seldridge
seldridge approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I had some questions if this would "just work" for groups and it does. 💯

test/Dialect/FIRRTL/errors.mlir Outdated Show resolved Hide resolved
@dtzSiFive dtzSiFive merged commit 4c8cb6b into llvm:main Aug 10, 2023
5 checks passed
@dtzSiFive dtzSiFive deleted the feature/rwprobe-op-use-after-def branch August 10, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

@youngar youngar Awaiting requested review from youngar

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzSiFive @seldridge