[CI] Attempt to fix nightly cache evictions #5826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short integration tests are filling the cache. Hopefully not appending the timestamp will replace rather than add new ones. Also attempt to enable sharing cache between nightly and short.
|
Nice! I didn't realize that setting the key was not enough, should have checked the cache. Here are two examples from right now: So, the ccache step is also prepending the keys with These two jobs have slightly different cmake flags, might want to make the completely identical if they are going to share a cache. Nightly has these two additional flags: I would also consider putting a note in each file that they should be kept in sync. |
|
Merging this and waiting a few days to see how effective it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short integration tests are filling the cache. Hopefully not appending the timestamp will replace rather than add new ones. Also attempt to enable sharing cache between nightly and short.