[HW] Fold extracts of constant structs #6010
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fold
hw.struct_extract
operations ofhw.aggregate_constant
to the constant value of their respective field.This breaks a test in HWtoLLVM, which checks correct conversion of the
extract(constant)
pattern. Since dialect conversion inevitably performs a fold on the input operations before converting, the extract operation will always end up ashw.constant
. There does not appear to be a dedicated test for converting constants, so I opted to just keep it in and adapt the expected output.