Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OM][LowerClass] Lower firrtl.integer to om.integer #6031

Merged
merged 2 commits into from
Sep 5, 2023
Merged

[OM][LowerClass] Lower firrtl.integer to om.integer #6031

merged 2 commits into from
Sep 5, 2023

Conversation

prithayan
Copy link
Contributor

Lower integer attributes to OM integer type.
Fixes #6019

dtzSiFive
dtzSiFive approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once the type PR lands, ofc).

@prithayan prithayan merged commit 56421f0 into main Sep 5, 2023
5 checks passed
@prithayan prithayan deleted the dev/pbarua/lowerclass_om_int branch September 5, 2023 15:41
@prithayan
Copy link
Contributor Author

Thanks for the review. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzSiFive dtzSiFive dtzSiFive approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OM] Need IntegerType? (or IR/LowerClasses bug)
2 participants
@prithayan @dtzSiFive