Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Gate classes behind firrtl version 3.2.0 #6043

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[FIRRTL] Gate classes behind firrtl version 3.2.0 #6043

merged 1 commit into from
Sep 5, 2023

Conversation

rwy7
Copy link
Contributor

@rwy7 rwy7 commented Sep 5, 2023

No description provided.

dtzSiFive
dtzSiFive approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

test/Dialect/FIRRTL/parse-errors.fir
skip

module Top:
; expected-error @below {{Inst types are a FIRRTL 3.2.0+ feature, but the specified FIRRTL version was 3.0.0}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes the Inst type feature check only reachable if encountered before (without?) a class being parsed (and rejected, as of this change)? Could collapse them but doesn't hurt to be more specific 👍 .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(added the tests back in)

@rwy7 rwy7 merged commit 3cfcf7a into llvm:main Sep 5, 2023
5 checks passed
@rwy7 rwy7 deleted the classes-fir-version branch September 5, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzSiFive dtzSiFive dtzSiFive approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rwy7 @dtzSiFive