[SV] Use a symbol in macro identifiers #6777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macro identifiers now use a proper symbol to handle references. The verifiers are not yet enabled as more intrusive pipeline changes are required, to be done in follow-ups.
nandor
requested review from
dtzSiFive,
darthscsi,
seldridge,
fabianschuiki and
maerhart
as code owners
uenoku
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
LGTM. I think it's reasonable approach to make verifySymbolUses empty and actually implement a follow-up. Could you open an issue to track that? Once verifySymbolUses is implemented, a serious of the changes will require downstream users to ensure uniqueness of the macro symbols so it would be nice to put a note on weekly meeting doc.
Comment on lines
+94
to
+105
| /// Verifies symbols referenced by macro identifiers. | ||
| static LogicalResult | ||
| verifyMacroIdentSymbolUses(Operation *op, FlatSymbolRefAttr attr, | ||
| SymbolTableCollection &symbolTable) { | ||
| auto *refOp = symbolTable.lookupNearestSymbolFrom(op, attr); | ||
| if (!refOp) | ||
| return op->emitError("references an undefined symbol: ") << attr; | ||
| if (!isa<MacroDeclOp>(refOp)) | ||
| return op->emitError("must reference a macro declaration"); | ||
| return success(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please feel free to land this change separately.
|
Opened #6779 to track this |
|
Awesome work, thanks for pushing on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macro identifiers now use a proper symbol to handle references. The verifiers are not yet enabled as more intrusive pipeline changes are required, to be done in follow-ups.