[HW][IST] Verify simple inner-ref-user ops sequentially, perf fix. #6850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an IRN has a huge number of top-level operations that need inner ref verification, the current code scaled poorly as the amount of per-op verification work is tiny (handful of hashtable lookups) compared to the overhead and atomic access of failableParallelForEach. Scan through the operations sequentially as a pre-pass and directly verify operations with no regions, only using parallelization for verifying recursive walks of modules.
|
All done here🫶❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an IRN has a huge number of top-level operations that need inner ref verification, the current code scaled poorly as the amount of per-op verification work is tiny (handful of hashtable lookups) compared to the overhead and atomic access of failableParallelForEach.
Scan through the operations sequentially as a pre-pass and directly verify operations with no regions, only using parallelization for verifying recursive walks of modules.